feat: impl SignableTransaction for OpTypedTransaction
#318
Conversation
ftupas
requested review from
mattsse,
emhane,
refcell and
clabby
as code owners
| { | ||
| match self { | ||
| Self::Deposit(tx) => { | ||
| Signed::new_unchecked(Self::Deposit(tx), TxDeposit::signature(), B256::ZERO) |
There was a problem hiding this comment.
this should use the deposit tx's from field here
| @@ -307,6 +336,61 @@ impl Transaction for OpTypedTransaction { | |||
| } | |||
| } | |||
|
|
|||
| impl SignableTransaction<Signature> for OpTypedTransaction { | |||
There was a problem hiding this comment.
hmm, we don't have this impl for typedtx on alloy,
need to figure out if we actually want this
| Self: Sized, | ||
| { | ||
| match self { | ||
| Self::Deposit(tx) => Signed::new_unchecked( |
There was a problem hiding this comment.
There is no concept of a "signed deposit tx", a deposit tx is authorized to exist by a log emitted from an L1 contract
There was a problem hiding this comment.
yeah,
given that we also don't this trait implemented for the ethereum typed enum and only for the actual raw transactions, this feels a bit odd, because a signed<TxDeposit> isn't useful.
can't think of a usecase where we'd need TypedTx -> Signed,
I assume the proper way to do this would be to convert it back to the TxRequest and then "build"/sign a valid tx type
Motivation
alloy_consensus::SignableTransactionforOpTypedTransactionalloy_consensus::SignableTransactionforOpTypedTransaction#315Solution
Delegate to inner transaction methods except for
TxDepositas it doesn't implementSignableTransactionPR Checklist