Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Impl RlpEcdsaTx for OpTypedTransaction #316

Open
emhane opened this issue Nov 29, 2024 · 4 comments
Open

[Feature] Impl RlpEcdsaTx for OpTypedTransaction #316

emhane opened this issue Nov 29, 2024 · 4 comments
Assignees
@htiennv
Labels
A-consensus Area: consensus crate good-first-issue Issues that are easy to pick up for new contributors

Comments

@emhane
Copy link
Collaborator

emhane commented Nov 29, 2024

Component

consensus

Describe the feature you would like

Impl alloy_consensus::RlpEcdsaTx for OpTypedTransaction
https://github.com/alloy-rs/alloy/blob/a33937d9f4a1c67d5ea06e8eb9ad443ffde900f7/crates/consensus/src/transaction/rlp.rs#L7-L217

Additional context

No response
@emhane emhane added A-consensus Area: consensus crate good-first-issue Issues that are easy to pick up for new contributors labels Nov 29, 2024
@emhane
Copy link
Collaborator Author

emhane commented Nov 29, 2024

another one I think is easy for you if you like @htiennv

@htiennv
Copy link
Contributor

htiennv commented Nov 29, 2024

thanks @emhane, i love it

@htiennv
Copy link
Contributor

htiennv commented Nov 29, 2024

Hi @emhane, i see alloy_consensus::RlpEcdsaTx is not public

https://github.com/alloy-rs/alloy/blob/20d13faff78325dda42de8952e0addad31d11db7/crates/consensus/src/lib.rs#L31

@mantosh-mariner
Copy link

Hi, I would like to work on this issue. Could you assign it to me?

@htiennv htiennv mentioned this issue Nov 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@htiennv htiennv

Labels
A-consensus Area: consensus crate good-first-issue Issues that are easy to pick up for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emhane @htiennv @mantosh-mariner