Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): public RlpEcdsaTx #1720

Closed
wants to merge 4 commits into from
Closed

Conversation

htiennv
Copy link

@htiennv htiennv commented Nov 30, 2024

Description

Public trait RlpEcdsaTx for implementation of OpTypedTransaction.

Ref: alloy-rs/op-alloy#316

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can re-export but I'd like to use a separete pub use and mark this as doc(hidden) because this is considered private API and should only be used by other network impl like op-alloy, if we really need it

@htiennv
Copy link
Author

htiennv commented Dec 12, 2024

Hi @mattsse, i was updated. Can you check it? Thanks

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually already exported

#[doc(hidden)]
pub use rlp::RlpEcdsaTx;

transaction::RlpEcdsaTx

@mattsse mattsse closed this Dec 12, 2024
@htiennv htiennv deleted the rlp branch December 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants