Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Use Upstream Forkchoice Version #326

Closed
refcell opened this issue Dec 3, 2024 · 2 comments · Fixed by #347
Closed

[Feature] Use Upstream Forkchoice Version #326

refcell opened this issue Dec 3, 2024 · 2 comments · Fixed by #347
Labels
A-rpc-types-engine Area: rpc-types-engine crate C-debt Category: technical debt or removable good-first-issue Issues that are easy to pick up for new contributors

Comments

@refcell
Copy link
Collaborator

refcell commented Dec 3, 2024

Component

rpc-types-engine

Describe the feature you would like

#321 introduced a new ForkchoiceUpdateVersion type that should be upstreamed to alloy-rpc-types-engine. This issue is to remove the ForkchoiceUpdateVersion type from op-alloy-rpc-types-engine once a versioned alloy-rpc-types-engine is used that includes the type.

Additional context

No response
@refcell refcell added A-rpc-types-engine Area: rpc-types-engine crate C-debt Category: technical debt or removable good-first-issue Issues that are easy to pick up for new contributors labels Dec 3, 2024
@refcell
Copy link
Collaborator Author

refcell commented Dec 3, 2024

(this issue is also to track upstreaming the type to alloy-rpc-type-engine, which is free to take on)

@refcell
Copy link
Collaborator Author

refcell commented Dec 3, 2024

Ref: alloy-rs/alloy#1744

Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2024
@programskillforverification
[Feature] Use Upstream Forkchoice Version (#347)
75b31ef 
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

close #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc-types-engine Area: rpc-types-engine crate C-debt Category: technical debt or removable good-first-issue Issues that are easy to pick up for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Use Upstream Forkchoice Version programskillforverification/op-alloy
1 participant
@refcell