Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): OP engine api trait ext + superchain signal type #117

Merged
merged 16 commits into from
Sep 22, 2024

Conversation

merklefruit
Copy link
Collaborator

Motivation

Adds a provider crate (op-alloy-provider) with some extension API traits for the OP engine API.
Additionally, adds the SuperchainSignal type along with the canonical decoding impl for the V0 type.

Ref: ithacaxyz/op-rs#11

@merklefruit merklefruit requested review from refcell and removed request for mattsse and emhane September 21, 2024 15:26
crates/rpc-types-engine/src/superchain.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/superchain.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/superchain.rs Show resolved Hide resolved
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits

crates/rpc-types-engine/Cargo.toml Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/superchain.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/superchain.rs Outdated Show resolved Hide resolved
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final nit hehe

pending CI

crates/rpc-types-engine/src/superchain.rs Outdated Show resolved Hide resolved
@merklefruit
Copy link
Collaborator Author

@mattsse done and added decoding tests from op-geth test vectors.
WASM target is failing for something related to "getrandom" lib - not sure how to address this

@mattsse mattsse merged commit 3683b4e into alloy-rs:main Sep 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants