[wip] feat: bump alloy #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed |
This was referenced Oct 30, 2024
klkvr
force-pushed
the
klkvr/bump-alloy
branch
from
f8896d1
to
1dc9552
Compare
refcell
reviewed
Nov 4, 2024
Cargo.toml
Outdated
Comment on lines
119
to
134
| [patch.crates-io] | ||
| alloy-sol-types = { git = "https://github.com/alloy-rs/core", rev = "17ae00a" } | ||
| alloy-primitives = { git = "https://github.com/alloy-rs/core", rev = "17ae00a" } | ||
|
|
||
| revm-primitives = { git = "https://github.com/klkvr/revm", rev = "82b99a0" } | ||
|
|
||
| alloy-consensus = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-network = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-network-primitives = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-rpc-types-eth = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-eips = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-serde = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-signer = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-provider = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } | ||
| alloy-transport = { git = "https://github.com/alloy-rs/alloy", rev = "d99f09c" } |
There was a problem hiding this comment.
Calling this out in a comment so we don't forget to remove these patches.
klkvr
force-pushed
the
klkvr/bump-alloy
branch
from
dd65caf
to
890c5df
Compare
mattsse
approved these changes
Nov 6, 2024
mattsse
added a commit
that referenced
this pull request
Nov 6, 2024
~~blocked by #205~~ ported from reth
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bumps alloy, alloy-core and alloy-eip7702.
Code changes:
fix: make a sensible encoding api alloy#1496 changed transaction encoding API, encoding functions are now prefixed with
rlp,eip2718ornetwork. I've updatedTxDepositto have methods following this patternrefactor: use simple boolean for parity in signature core#776 updated signature type to avoid using
Paritygeneric and instead just keep a boolean for parity byte. The motivation is to have more correctness in encoding and data structure. Before that it was possible to constructSigned<TxLegacy>where transaction chain_id isSome, but the parity would not follow EIP-155.This required a few changes to
SpanBatchTransactionstype:encode_y_parity_bitsandencode_tx_sigs_rsare merged into singleencode_tx_sigswhich firstly encodes parity bits and thenrsvalues. Same was done for decoding methodsrecover_vmethod is removed. instead, we now pass theis_protectedflag down toSpanBatchLegacyTransactionDataand only setchain_idtoSomewhenis_protectedis trueBlocked by minor releases for alloy, core and revm
Solution
PR Checklist