-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(consensus): Trait Abstracted Hardforks #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
A-consensus
Area: consensus crate
C-hardfork
Category: Hardfork related changes
labels
Nov 19, 2024
refcell
changed the title
chore(consensus): Trait Abstract Hardforks
chore(consensus): Trait Abstracted Hardforks
Nov 19, 2024
emhane
reviewed
Nov 19, 2024
mattsse
previously requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for debugging purposes, could be useful to have an iterator over txenvelope and the trait function does a map (encode2718)
refcell
force-pushed
the
rf/chore/trait-abstracted-hardforks
branch
from
November 19, 2024 18:52
1579efd
to
a1c7a78
Compare
emhane
approved these changes
Nov 19, 2024
refcell
added a commit
that referenced
this pull request
Nov 21, 2024
### Description Trait abstracts hardforks to make them more ergonomic to extend, modify, or introduce a new hardfork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trait abstracts hardforks to make them more ergonomic to extend, modify, or introduce a new hardfork.