Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): Trait Abstracted Hardforks #289

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 19, 2024

Description

Trait abstracts hardforks to make them more ergonomic to extend, modify, or introduce a new hardfork.

@refcell refcell added A-consensus Area: consensus crate C-hardfork Category: Hardfork related changes labels Nov 19, 2024
@refcell refcell changed the title chore(consensus): Trait Abstract Hardforks chore(consensus): Trait Abstracted Hardforks Nov 19, 2024
@refcell refcell self-assigned this Nov 19, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debugging purposes, could be useful to have an iterator over txenvelope and the trait function does a map (encode2718)

@refcell refcell force-pushed the rf/chore/trait-abstracted-hardforks branch from 1579efd to a1c7a78 Compare November 19, 2024 18:52
@refcell refcell requested a review from mattsse November 19, 2024 19:43
@refcell refcell dismissed mattsse’s stale review November 20, 2024 11:07

implemented request

@refcell refcell added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 022f6f5 Nov 20, 2024
19 checks passed
@refcell refcell deleted the rf/chore/trait-abstracted-hardforks branch November 20, 2024 11:07
refcell added a commit that referenced this pull request Nov 21, 2024
### Description

Trait abstracts hardforks to make them more ergonomic to extend, modify,
or introduce a new hardfork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: consensus crate C-hardfork Category: Hardfork related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants