Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): Remove panic in brotli compress method #296

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 21, 2024

Description

Removes an unintended panic in the brotli compression method.

@refcell refcell added A-protocol Area: protocol crate C-bug Category: Something isn't working labels Nov 21, 2024
@refcell
Copy link
Collaborator Author

refcell commented Nov 21, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one suggestion

crates/consensus/src/hardforks/ecotone.rs Outdated Show resolved Hide resolved
crates/consensus/src/hardforks/forks.rs Show resolved Hide resolved
@refcell refcell force-pushed the rf/feat/protocol-fixes branch 2 times, most recently from 1b4450e to 5e319f9 Compare November 21, 2024 19:09
@mattsse
Copy link
Member

mattsse commented Nov 21, 2024

@refcell for txdeposit we can actually move all of those into the trait impl Encode/Decode2718

/// Get the length of the transaction when EIP-2718 encoded. This is the
/// 1 byte type flag + the length of the RLP encoded transaction.
pub fn eip2718_encoded_length(&self) -> usize {
self.rlp_encoded_length() + 1
}

@refcell refcell added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 4356317 Nov 21, 2024
20 checks passed
@refcell refcell deleted the rf/feat/protocol-fixes branch November 21, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-protocol Area: protocol crate C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants