fix root updates bug in hash_builder #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: fix unit test error
feat: add test case
chengzhinei
approved these changes
Aug 6, 2024
pad all valid root_hash
fix: not panic key seq
Signed-off-by: Charles Ferrell <charlie@manta.network>
Bump alloy version
Signed-off-by: Charles Ferrell <charlie@manta.network>
bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for implementing such an amazing crate to help merkle particia tree calculation.
During using, we found some weird updating case and made the smallest reproducible prototype. we add a
test_updates_roottest case to track updating, but nothing generated. and then we add atest_top_branch_logicto track every branch in codebaseupdate. And we think thestore_branch_nodehas some logic bug.This bug will leads to that some branch nodes are not pushed into updates currently, but it doesn't affect the root calculation progress since it has no matters with the
stacklogic.To reproduce the error, maybe you can just call
test_updates_rootdirectly. The origin call will get an empty updates, which is not reasonable.We also refer the origin design doc on erigon, seems nothing clear about
add_branchlogic mentioned.So, maybe we don't understand the logic currently (like some branch that did not generate updates were intentionally skipped), so can u plz offer some metarial to explain? Or hope this fix helps, we are willing to contribute to this repo constantly.
thanks,