Skip to content

Commit

Permalink
fix string utils class (#339)
Browse files Browse the repository at this point in the history
  • Loading branch information
vbragin committed Feb 2, 2024
1 parent 3186628 commit b5cce76
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>io.qameta.allure</groupId>
<artifactId>allure-bamboo</artifactId>
<version>1.17.0-SNAPSHOT</version>
<version>1.18.0-SNAPSHOT</version>
<name>Allure for Bamboo</name>
<description>Allure reports right in deployment plans in Bamboo</description>
<packaging>atlassian-plugin</packaging>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import static io.qameta.allure.bamboo.AllureConstants.ALLURE_BUILD_REPORT_FAILURE_DETAILS;
import static io.qameta.allure.bamboo.AllureConstants.ALLURE_BUILD_REPORT_SUCCESS;
import static java.lang.Boolean.parseBoolean;
import static org.sonatype.aether.util.StringUtils.isEmpty;
import static org.apache.commons.lang3.StringUtils.isEmpty;

class AllureBuildResult implements Serializable {
private final boolean success;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.atlassian.bamboo.resultsummary.ResultsSummary;
import com.atlassian.bamboo.resultsummary.ResultsSummaryManager;
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -41,7 +42,6 @@
import static com.atlassian.bamboo.plan.PlanKeys.getPlanResultKey;
import static io.qameta.allure.bamboo.AllureBuildResult.fromCustomData;
import static java.lang.Integer.parseInt;
import static org.sonatype.aether.util.StringUtils.isEmpty;

public class AllureReportServlet extends HttpServlet {

Expand Down Expand Up @@ -149,7 +149,7 @@ private boolean wasUploadSuccess(final HttpServletResponse response,

private void uploadResultWasNotSuccess(final HttpServletResponse response,
final AllureBuildResult uploadResult) {
final String errorMessage = isEmpty(uploadResult.getFailureDetails())
final String errorMessage = StringUtils.isEmpty(uploadResult.getFailureDetails())
? "Unknown error has occurred during Allure Build. Please refer the server logs for details."
: "Something went wrong with Allure Report generation. Here are some details: \n"
+ uploadResult.getFailureDetails();
Expand Down

0 comments on commit b5cce76

Please sign in to comment.