Mayor Refactor - Compatibility with new Bamboo API and report improvements #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Historical Fixes > Allure binary download, unzip, and so on was updated > All libraries was updated to newer versions > Removed the error when you add the allure task to any plan (only a log message is shown) Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
…ckslashes together when filePath is concatenated > AllureBuildCompleteAction: Fixing Report URL in the executor.json file. > AllureCommandLineSupport: Increasing timeout to 5 minutes > AllureReportServlet: Rollback URL Pattern Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
…so on). Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
> Bug: When you try to uncheck an option from Bamboo UI the option is not saved. > Download Util class we created to download logo and allure binary > The deprecated logo was changed due to it being confused. (It is not deprecated, it is just not necessary) > The task description was changed > Bug: If you add an allure task to your plan the build fails due to API incompatibility Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
… next execution. Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
> Allure removed from the title. (it's not customizable) > A link was created to download the report for evidence in other systems. > The logo can have other types not only SVG. > Fix some dependencies conflicts Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
…major." This reverts commit d873df7.
…sion is major."" This reverts commit e143ff0.
|
I need to create a new fork and pull request because I didn't sign my commits. Thanks! |
|
@eroshenkoam please could you help me with this PR? Thanks! |
|
Hi @baev, thanks to execute the required build but, it's failing when it try to download a dependency. I am not able to reproduce that issue on my machine, I can generate a jar properly, using atlas-package after doing atlas-clean. |
|
The bin that I generated: https://drive.google.com/file/d/1SyylGaE5-ZovT18NJ5KwJ55gS63qWUBp/view?usp=sharing Command used: atlas-package |
|
@lararojasmr hello sir, |
|
@lararojasmr Manuel, could you please check your email? |
vbragin
requested changes
Sep 8, 2022
src/main/java/io/qameta/allure/bamboo/AllureArtifactsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/io/qameta/allure/bamboo/AllureBuildCompleteAction.java
Outdated
Show resolved
Hide resolved
src/main/java/io/qameta/allure/bamboo/info/allurewidgets/summary/Summary.java
Outdated
Show resolved
Hide resolved
src/main/java/io/qameta/allure/bamboo/info/allurewidgets/summary/Summary.java
Outdated
Show resolved
Hide resolved
src/main/java/io/qameta/allure/bamboo/info/allurewidgets/summary/Time.java
Outdated
Show resolved
Hide resolved
src/main/java/io/qameta/allure/bamboo/info/allurewidgets/summary/Time.java
Outdated
Show resolved
Hide resolved
src/main/java/io/qameta/allure/bamboo/info/allurewidgets/summary/Time.java
Outdated
Show resolved
Hide resolved
Thanks @cheshi-mantu. I'll make these changes, sorry I have been with a lot of work these days. |
|
@lararojasmr Hi Manuel, |
|
Yes, but let me make all the changes that you suggested. I have had a lot
of work in the past months, so I haven't had the chance to make it. But,
before 2023, I hope to have all changes done. Thanks!
*Ing. Manuel Lara*
*LinkedIn: *https://ve.linkedin.com/in/ingmanuellara
El jue, 24 nov 2022 a la(s) 09:44, Egor Ivanov ***@***.***)
escribió:
… @lararojasmr <https://github.com/lararojasmr> Hi Manuel,
have you had a chance to review?
thanks
—
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUAQ4J7SXRV7G7JXCWUJLDWJ5WLFANCNFSM57BYZ4ZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi, I'm working to fix all your comments. Sorry for the delay! |
> amps.version to 8.0.3-89c970d65 Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
Signed-off-by: Manuel Lara <lararojas.mr@gmail.com>
|
@cheshi-mantu it's ready to merge! |
|
@vbragin have you had a chance the updates? |
vbragin
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a big refactor for all plugin it's fully tested in a bamboo evaluation environment and offer complete compatibility with the new API. Several bugs were solved in this version, and it's not compatible with the last release so I propose version 2.0.
The logo is customizable, the Allure Report Title is set by the plugin, and the report is exportable to a zip file. The history is generated properly, and the historical links work fine. Those are some of the changes that I made.
Details in commits details.