Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix await issues #107

Closed
wants to merge 2 commits into from
Closed

Fix await issues #107

wants to merge 2 commits into from

Conversation

unickq
Copy link
Contributor

@unickq unickq commented May 8, 2020 •
edited
Loading

@VictorYakushenko
Copy link

Hi! I tried this fix and it will create a new bug with parallelizing.
Steps to repro: run tests concurrently with NUnit parallelize attribute.

When I use Nunit Property Bag as storage, it completely fixes the problem, but it can't be used as a real fix

@unickq unickq closed this Dec 1, 2020
@gray-oni
Copy link

Hi @VictorYakushenko @unickq
I know that it's a pretty old and closed PR, however, maybe you can clarify with a bit more details which issues you faced during using Parallelization functionality within NUnit using this fix?
I have a similar fix using AsyncLocal + the fix for .NET 4.5 platform. However, I wasn't able to reproduce any issue using Parallelizable functionality on my test NUnit project.

@CraigRichards
Copy link
Contributor

I see this issue a lot and would be interested in what you new bug was and how to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unickq @VictorYakushenko @gray-oni @CraigRichards