-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for async NUnit tests #314
Conversation
Hello, @overlord ! Looks like it solves this issue completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution, could you look at review?
230e593
to
a90882d
Compare
a90882d
to
c0fd75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove accidentally added file please.
.editorconfig
Outdated
@@ -0,0 +1,24 @@ | |||
# EditorConfig is awesome: http://EditorConfig.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be removed
This pull request provides workaround or maybe even fixes the issues (in
Allure.NUnit 2.9.2-preview.1
) with async test methods in NUnit.Allure.It fixes the case when async methods marked with
[AllureStep]
like the following:fails in runtime with exception like the following:
The main problem was in the ThreadStatic field
AllureStorage.stepContext
- that fails on cross-thread execution of async methods.I have tried to fix it and have provided some unit tests for new async behaviour (see.
Allure.NUnit.AsyncTests.AsyncLifeCycleTests
)