compare the keyword type case insensitive #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyword type is changed in RF 4.0. To support RF 3.x and RF 4.0, I think we should do the comparison case insensitively.
vlads11
approved these changes
Mar 15, 2021
|
@skhomuti @sseliverstov Do you have time to take a look at this PR? This blocks us from upgrading to RF 4 😂 |
|
@mattbzhang fixed via #576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of keyword types are changed in RF 4.0. The can lead to setup and teardown are missing in the allure report.
To support RF 3.x and RF 4.0, I think we should do the comparison case insensitively.
Refer to the RF User Guide for details about the change of the keyword type in RF 4.0 - http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#listener-interface
//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Checklist