Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows ESM issue #48

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix windows ESM issue #48

merged 2 commits into from
Jan 6, 2025
+23 −2

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Dec 24, 2024

fixes #47

@epszaw epszaw added the type:bug Something isn't working label Dec 24, 2024
@epszaw epszaw requested a review from delatrie December 24, 2024 14:30
@epszaw epszaw requested a review from delatrie January 6, 2025 09:10
@epszaw epszaw force-pushed the fix-windows-es-path-issue branch from 9f9524d to 8383e6d Compare January 6, 2025 09:40
delatrie
delatrie approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epszaw epszaw merged commit 0badb58 into main Jan 6, 2025
4 checks passed
@epszaw epszaw deleted the fix-windows-es-path-issue branch January 6, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delatrie delatrie delatrie approved these changes

Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error code: ‘ERR_UNSUPPORTED_ESM_URL_SCHEME’ when trying to generate a report
2 participants
@epszaw @delatrie