Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #501

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Dependency updates #501

merged 4 commits into from
Sep 14, 2022

Conversation

RvanderLaan
Copy link
Collaborator

Updated most dependencies using yarn upgrade --interactive --latest

Major upgrades:

  • React 17 -> 18
  • Electron 18 -> 20

I skimmed the release notes and found no breaking changes relevant to us

The only real change I noticed is that the frame of the settings window (and others) now match the light/dark theme

Major upgrades:
- React 17 -> 18
- Electron 18 -> 20
package.json Outdated Show resolved Hide resolved
src/frontend/components/TagSelector.tsx Show resolved Hide resolved
src/frontend/containers/Settings/index.tsx Outdated Show resolved Hide resolved
src/renderer.tsx Show resolved Hide resolved
@hummingly hummingly merged commit 673bfa2 into master Sep 14, 2022
@hummingly
Copy link
Collaborator

I reverted two changes:

  • bumping the version and
  • adding extra text to the hierarchy separator options.

The first because I think it is better to do update the version in a separate commit and for the second change I don't know if it is a good change. It creates more noise in my opinion. A separate PR for the change can be re-openend if there was a good reason.

@hummingly hummingly deleted the updated-deps-aug-22 branch September 14, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants