fix(DataSet): make sure the right id-type is used internaly

This fixes a fixed strange string-number conversion issue. It can happen that id "0" !== 0 what causes #2580. fixes #2580
almende · Jan 15, 2017 · ef5b291 · ef5b291
1 parent 594c1db
commit ef5b291
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/examples/graph2d/08_performance.html b/examples/graph2d/08_performance.html
@@ -147,4 +147,4 @@ <h2>Graph2d | Performance</h2>
     var graph2d = new vis.Graph2d(container, dataset, options);
 </script>
 </body>
-</html>
+</html>
diff --git a/lib/DataSet.js b/lib/DataSet.js
@@ -730,7 +730,7 @@ DataSet.prototype.clear = function (senderId) {
   var i, len;
   var ids = Object.keys(this._data);
   var items = [];
-  
+
   for (i = 0, len = ids.length; i < len; i++) {
     items.push(this._data[ids[i]]);
   }
@@ -912,7 +912,7 @@ DataSet.prototype._getItem = function (id, types) {
   }
 
   if (!converted[this._fieldId]) {
-    converted[this._fieldId] = id;
+    converted[this._fieldId] = raw.id;
   }
 
   return converted;
-Original file line number
+Diff line change
@@ Expand Up / @@ -147,4 +147,4 @@ <h2>Graph2d | Performance</h2> @@
         var graph2d = new vis.Graph2d(container, dataset, options);
     </script>
     </body>
-    </html>
+    </html>