Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Bug in TimeStep.prototype.getClassName #2319

Closed
dboire opened this issue Nov 15, 2016 · 0 comments
Closed

Bug in TimeStep.prototype.getClassName #2319

dboire opened this issue Nov 15, 2016 · 0 comments

Comments

@dboire
Copy link

dboire commented Nov 15, 2016

I dont find it in forum, and it look like a bug :

TimeStep.prototype.getClassName :
case 'day': (and maybe some other)

return 'vis-day' + current.date() + ' vis-' + current.format('MMMM').toLowerCase() + today(current) + currentMonth(current) + this.step <= 2 ? today(current) : '' + this.step <= 2 ? ' vis-' + current.format('dddd').toLowerCase() : '' + even(current.date() - 1);

the first part :
'vis-day' + current.date() + ' vis-' + current.format('MMMM').toLowerCase() + today(current) + currentMonth(current)
is used in condition calculation, and therefore, never added in html
Some bracket may be needed

@yotamberk yotamberk mentioned this issue Nov 19, 2016
mojoaxel pushed a commit that referenced this issue Nov 20, 2016
* Fix brackets problem
* Fix timeStep.getClassName
@mojoaxel mojoaxel added this to the Minor Release v4.18 milestone Nov 22, 2016
@wimrijnders wimrijnders marked this as a duplicate of #3293 Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants