Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Timeline option throttleRedraw was removed without increasing MAJOR version number #2511

Closed
mojoaxel opened this issue Dec 28, 2016 · 3 comments
Closed

Timeline option throttleRedraw was removed without increasing MAJOR version number #2511

mojoaxel opened this issue Dec 28, 2016 · 3 comments
Milestone
Minor Release v4.18

Comments

@mojoaxel
Copy link
Member

mojoaxel commented Dec 28, 2016 •
edited
Loading

see #1766 (comment)

Remove a public (documented) option is a "breaking change". Breaking changes need a Major Version update.
@mojoaxel mojoaxel added this to the Minor Release v4.18 milestone Dec 28, 2016
@mojoaxel mojoaxel mentioned this issue Dec 28, 2016
Closed
@mojoaxel
Copy link
Member Author

mojoaxel commented Dec 28, 2016 •
edited
Loading

This was introduced by #2091 with c130f0b
WE NEED TO BE MORE CAREFULL!

@mojoaxel mojoaxel mentioned this issue Dec 28, 2016
Merged
@yotamberk
Copy link
Contributor

@mojoaxel I agree. We didn't think about that at the time we approved it. We can add a stub redrawThrottle saying in the console that this option has been deprecated and will be removed in the next major. What do you think?

mojoaxel added a commit that referenced this issue Dec 30, 2016
@mojoaxel
readded depricated option throttleRedraw; fixes #2511

Verified

This commit was signed with the committer’s verified signature.
scala-steward Scala Steward
GPG key ID: 7FE176635A140508
Verified
Learn about vigilant mode
3feda19
@mojoaxel mojoaxel mentioned this issue Dec 30, 2016
Merged
yotamberk pushed a commit that referenced this issue Dec 30, 2016
@mojoaxel @yotamberk
readded throttleRedraw (#2514)
1eb05e5 
* readded depricated option throttleRedraw; fixes #2511

* added doc style for depricated options
@mojoaxel
Copy link
Member Author

Fixed with #2514 by re-adding docs for trottleRedraw. If used a "deprecated" warning is thrown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Minor Release v4.18
Development

No branches or pull requests
2 participants
@mojoaxel @yotamberk