-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Network] self-loop edge not always show with 4.18 #2591
Comments
Can you provide a minimal example showing the problem via jsbin.com. Please also let us know how to reproduce the error using the example. |
Short example : http://jsbin.com/fipaha/edit?html Seems to be with dot shape. Edge from node 1 to node 1 is not always visibled (clicking Nodes / moving nodes, ....) |
I can confirm this bug. It works with 4.17 and breaks in 4.18. Thus, it was introduced in 4.18 :( |
Not only for |
For me, the issue can be seen: • when opening the network, the link-to-self loop is missing... and then simply clicking on the canvas displays the loop. must be related to drawing that edge... The code in network/modules/components/edges/util/EdgeBase.js lines 60, 61; 86, 87; and 101, 102 is where the loop circle is getting drawn... looks like _getCircleData is a potential culprit. |
And moving others nodes without loop then loop flash |
I've got a fix for this one... I'll be doing a PR shortly. |
#2595) * self reference edge should now appear in all cases * add checks for shape width being NaN to get correct circle data * reorder resize arguments in Diamond, Dot and Star
@bthieurmel Thanks for reporting this! |
When network have "self-loop" edge (from = 1, to = 1), they are not always showed, depends of movement :
The text was updated successfully, but these errors were encountered: