Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

[ERROR] manipulationEditEdgeNoDrag crash when cancel edit #2856

Closed
golflv100 opened this issue Mar 12, 2017 · 0 comments
Closed

[ERROR] manipulationEditEdgeNoDrag crash when cancel edit #2856

golflv100 opened this issue Mar 12, 2017 · 0 comments

Comments

@golflv100
Copy link

golflv100 commented Mar 12, 2017

If you click edit node and cancel it. The tools bar will crash.

http://visjs.org/examples/network/other/manipulationEditEdgeNoDrag.html

and also if you click edit node and save it. the node will have a nodeshadow on it.

It's not happen on manipulation file.

http://visjs.org/examples/network/other/manipulation.html

@Tooa Tooa added this to the Minor Release v4.20 milestone Mar 12, 2017
@mojoaxel mojoaxel modified the milestones: Minor Release v4.20, Patch Release v4.20.1 May 21, 2017
wimrijnders added a commit to wimrijnders/vis that referenced this issue Jul 18, 2017
Fix for almende#2856

- Toolbar gets reshown when cancelling edit node dialog
- No shadow displayed upon save in edit node dialog

The latter is actually a more general problem. Function `mergeOptions` in `util.js`
made an assumption as to the correct value of field `enabled`. It now takes the value
from `globalOptions`, if present.
yotamberk pushed a commit that referenced this issue Jul 20, 2017
Fix for #2856

- Toolbar gets reshown when cancelling edit node dialog
- No shadow displayed upon save in edit node dialog

The latter is actually a more general problem. Function `mergeOptions` in `util.js`
made an assumption as to the correct value of field `enabled`. It now takes the value
from `globalOptions`, if present.
primozs pushed a commit to primozs/vis that referenced this issue Jan 3, 2019
Fix for almende#2856

- Toolbar gets reshown when cancelling edit node dialog
- No shadow displayed upon save in edit node dialog

The latter is actually a more general problem. Function `mergeOptions` in `util.js`
made an assumption as to the correct value of field `enabled`. It now takes the value
from `globalOptions`, if present.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants