This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Group click event when collapsing nested group contains null group ID #2877
Milestone
Comments
|
@yotamberk Bug or Feature-Request? |
|
I believe it's a problem but not a high priority one |
|
Fix demo here: https://plnkr.co/edit/fsYp8dujYp4WZloM17Xt?p=preview PR incoming... |
BTMorton
pushed a commit
to BTMorton/vis
that referenced
this issue
Apr 15, 2017
yotamberk
pushed a commit
that referenced
this issue
Apr 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a group with nested groups is collapsed, the
clickevent that is triggered does not contain the group ID, which makes tracking the toggle of nested group visibility more difficult.Example can be seen at https://plnkr.co/edit/GdoPTGkda2w0acanUvxL?p=preview. To reproduce, hide the nested group and check printed event log.
I managed to track this down to the
groupIdsproperty of theItemSetbeing empty. It's set to an empty array on line 418 of ItemSet.js in themarkDirtyfunction. I don't know if this is a requirement for something later in the process or not, so I didn't make a PR for it.The text was updated successfully, but these errors were encountered: