Error when id equals 0 in getEdgeAt function

[steven-network]

Hi all,

I discovered a bug in your library when getEdgeAt function is called when edge id equals 0.

key: 'getEdgeAt',
      value: function getEdgeAt(pointer) {
        var returnEdge = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : true;

        // Iterate over edges, pick closest within 10
        var canvasPos = this.canvas.DOMtoCanvas(pointer);
        var mindist = 10;
        var overlappingEdge = null;
        var edges = this.body.edges;
        for (var i = 0; i < this.body.edgeIndices.length; i++) {
          var edgeId = this.body.edgeIndices[i];
          var edge = edges[edgeId];
          if (edge.connected) {
            var xFrom = edge.from.x;
            var yFrom = edge.from.y;
            var xTo = edge.to.x;
            var yTo = edge.to.y;
            var dist = edge.edgeType.getDistanceToEdge(xFrom, yFrom, xTo, yTo, canvasPos.x, canvasPos.y);
            if (dist < mindist) {
              overlappingEdge = edgeId;
              mindist = dist;
            }
          }
        }
        if (overlappingEdge !== null) { // Here if ID = 0, return undefined
          if (returnEdge === true) {
            return this.body.edges[overlappingEdge];
          } else {
            return overlappingEdge;
          }
        } else {
          return undefined;
        }
      }

I added "overlappingEdge !== null" to return id even if it is 0.

[bradh]

@wimrijnders Is this the same as #2936 (fixed pending release)?

[wimrijnders]

@bradh No, not the same.

The solution is valid. I'll make a PR for this. We really need a way to detect this kind of errors. I hope we can agree on the usage of jslint RSN.

[wimrijnders]

@steven-network Thanks for reporting!

[steven-network]

@wimrijnders you're welcome!