Add the source data to Point3d objects in Graph3D #1884
Conversation
| @@ -589,6 +590,7 @@ Graph3d.prototype._getDataPoints = function (data) { | |||
| point.x = data[i][this.colX] || 0; | |||
| point.y = data[i][this.colY] || 0; | |||
| point.z = data[i][this.colZ] || 0; | |||
| point.source = data[i]; | |||
There was a problem hiding this comment.
About the naming: I personally would prefer point.data over point.source
|
@TRManderson Could you maybe extend the graph3d tooltips example to use the new data? In any case this new feature should be documented and explained here. Thanks! |
|
Updated to include docs and example change. I couldn't come up with a compelling extension to the tooltips example, but I think I demonstrated the functionality non-horribly. |
| } | ||
| else { | ||
| data.add({x:x, y:y, z: z}); | ||
| data.add({x:x, y:y, z: z, extra: extra_content[(x*y) % extra_content.length]}); |
There was a problem hiding this comment.
Can you please change the ident every where from "tab" to "spaces". (I also don't like it, but ithe the projects standart.)
mojoaxel
added
waiting for answer/improvement
and removed
waiting for answer/improvement
labels
This allows more complex tooltips, using information sent from the server + the source object
Vim config was off, edited in sublime instead
|
Sorry about that - dodgy vim config meant I was typing tabs when I thought I had spaces. I've rebased develop with the changes requested. |
|
@TRManderson Thanks! |
This allows more complex tooltips, using information sent from the server + the source object