This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Select the closest edge, not just any nearby #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue descriped is realy easy to reproduce with the worldCup example. |
|
I tested it. Looks Good! |
|
@root9b Thanks very much! Nice improvement! Sorry that you had to wait so long for this to get merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps quite a bit for complex graphs with dense connections, where many edges are packed into a small space. With the default algorithm, any edge within 10 of the mouse will get selected, so there are often edges you are unable to select at all even though you can see them, because others are nearby. With this patch, you can be much more precise with where you are clicking and which edge you are selecting.