This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Create ItemRangeOverflow item type #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
than the width of the text. This prevents range items with longer text lines from being completely hidden. Also update the stacking collision check to handle this case so that the overflowed text is not hidden by another item.
Conflicts: src/timeline/component/css/item.css vis.js vis.min.js
Conflicts: vis.min.js
timeline on any given date.
object is already a moment instance. Calling moment(object) will clone it per tehe moment docs http://momentjs.com/docs/#/parsing/moment-clone/
Conflicts: vis.js vis.min.js
Overflow simply extends ItemRange with a new getWidth() function that determines if the content of the range is wider than the range box itself. This did require adding a getWidth() function to the Item object that always just returns this.width, and adjusting Stack.js to use the new getWidth() function instead of item.width
|
Nice work. Right now only the |
josdejong
added a commit
that referenced
this pull request
Nov 1, 2013
Create ItemRangeOverflow item type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overflow simply extends ItemRange with a new getWidth() function that
determines if the content of the range is wider than the range box
itself.
This did require adding a getWidth() function to the Item object that
always just returns this.width, and adjusting Stack.js to use the new
getWidth() function instead of item.width
This properly fixes and closes #1