This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Consolidated code for drawing x-axis label #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, fine with me. |
|
That sounds good to me |
|
@wimrijnders Looks good. Feel free to add more changes concerning the axis labels. |
|
Ok. I'm missing my upward thumb emoticon here - (y) in skype. Will do it this afternoon, have some other tasks now. |
|
Oh, merged already. Never mind, I'll make a new PR for the Y and Z labels. |
start with a ":" |
|
👍 Ha! Thank you. Very important, this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drawing of the axis labels occurs in two places and are chunks of non-trivial code. Hence I think it is a good idea to consolidate these.
This PR contains a new single method for drawing labels for the x-axis. If you can agree with this, I will do the y and z axis labels in a similar manner. Awaiting your response.