This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Common handling for settings with prefix 'default' #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojoaxel
approved these changes
Oct 20, 2016
|
That's quick. Do you really check all the changes? |
No, I had a quick look and realized it's again just refactoring. I trust that you test your changes. |
|
Testing: Always. For every PR and every change I make within the PR. It's not completely refactoring; I added some extra functionality to make the handling of the last settings possible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the final user settings to the defaults. Handling of the settings is now complete.