This repository was archived by the owner on Jul 29, 2019. It is now read-only.
vertical scroll when zoomKey isn't triggered #2197
Merged
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yotamberk
changed the title
yotamberk
changed the title
mojoaxel
suggested changes
Oct 20, 2016
| @@ -222,7 +251,7 @@ Core.prototype.setOptions = function (options) { | |||
| var fields = [ | |||
| 'width', 'height', 'minHeight', 'maxHeight', 'autoResize', | |||
| 'start', 'end', 'clickToUse', 'dataAttributes', 'hiddenDates', | |||
| 'locale', 'locales', 'moment', 'rtl' | |||
| 'locale', 'locales', 'moment', 'rtl', 'zoomKey' | |||
There was a problem hiding this comment.
zoomKey looks like a new option. I think we need some documentation for that.
There was a problem hiding this comment.
It's not new, it's simply not exposed in the core.js file so we need to expose it like this.
| @@ -161,6 +161,35 @@ Core.prototype._create = function (container) { | |||
| this.dom.root.addEventListener('mousewheel', onMouseWheel); | |||
There was a problem hiding this comment.
I would suggest to use the chance an change the existing mousewheel handler to something more generic:
if (this.dom.root.addEventListener) {
// IE9, Chrome, Safari, Opera
this.dom.root.addEventListener("mousewheel", MouseWheelHandler, false);
// Firefox
this.dom.root.addEventListener("DOMMouseScroll", MouseWheelHandler, false);
} else {
// IE 6/7/8
this.dom.root.attachEvent("onmousewheel", MouseWheelHandler);
}| event.preventDefault(); | ||
| } | ||
|
|
||
| this.dom.center.addEventListener('mousewheel', onMouseWheelCenter); |
There was a problem hiding this comment.
There is already a mousewheel handler on the root element. For performance-reasons we should only attach it once and reuse the onMouseWheel function.
|
Fixed comments! On to the next PR |
mojoaxel
approved these changes
Oct 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.