Some code cleanup and consolidation. #2204

wimrijnders · 2016-10-22T07:32:52Z

A round of cleaning up some stuff before making bigger changes.

Removed method _determineColumnIndexes(). It's not being used and useless as it is.
Moved code for checking consistency value field to its own method.
Replace line drawing code with call to _line() - 1 instance
Used aliases for certain variables paths when these were obvious - 3 instances.
Combined line drawing code for grid style
removed/added empty lines
some comment cleanup (mostly my own)

yotamberk · 2016-10-22T08:14:22Z

lib/graph3d/Graph3d.js

-    ctx.stroke();
+    from  = new Point2d(left - gridLineLen, y);
+    to    = new Point2d(left, y);
+		this._line(ctx, from, to);


There is an extra indent here

wimrijnders · 2016-10-22T08:16:13Z

OK fixing it. Don't merge yet.

wimrijnders added 2 commits October 21, 2016 19:23

Small code cleanup and consolidation.

3d0acba

Fixes after testing

13752ed

yotamberk reviewed Oct 22, 2016

View reviewed changes

yotamberk approved these changes Oct 22, 2016

View reviewed changes

Fixed another silly indent

cd1b18f

yotamberk merged commit 25a04fc into almende:develop Oct 22, 2016

wimrijnders deleted the PR17 branch October 22, 2016 22:48

Provide feedback