This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix scroll bugs with vertical scrollbar #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tooa
approved these changes
Oct 25, 2016
| } | ||
|
|
||
| function onMouseScrollSide(event) { | ||
| var current = this.scrollTop; | ||
| var adjusted = -current; | ||
| if (!me.options.verticalScroll) return; |
There was a problem hiding this comment.
You should add curly braces here in order to be consistent with the code style.
| @@ -1070,6 +1072,7 @@ Core.prototype._onPinch = function (event) { | |||
| * @private | |||
| */ | |||
| Core.prototype._onDrag = function (event) { | |||
| if (!event) return | |||
There was a problem hiding this comment.
Add curly braces and missing ;. See my comment above.
| @@ -109,6 +104,11 @@ function Timeline (container, items, groups, options) { | |||
| // current time bar | |||
| this.currentTime = new CurrentTime(this.body); | |||
| this.components.push(this.currentTime); | |||
|
|
|||
| // apply options | |||
| if (options) { | |||
There was a problem hiding this comment.
Here we have the braces. Is this some Javascript style convention to omit them if it's a return? I'm not sure.
| @@ -390,6 +390,8 @@ Range.prototype._onDragStart = function(event) { | |||
| * @private | |||
| */ | |||
| Range.prototype._onDrag = function (event) { | |||
| if (!event) return | |||
mojoaxel
approved these changes
Oct 25, 2016
There was a problem hiding this comment.
I think in case of only a "return" we don't have to force curly brackets. It's just tast!
@yotamberk Do you want to change it or leave it? Should I merge?
|
@mojoaxel I kind of prefer without the curly braces. But it is a question of style. I think you can accept it like this. If we decide later differently, i'll be glad to change it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.