Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Improvement for camera 3d moving #2340

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

linuxnotes
Copy link
Contributor

Improvement of camera moving for 3d graph

@yotamberk
Copy link
Contributor

Hey @linuxnotes , Thanks for the PR! Your PR is from the wrong branch to the wrong branch. Try again please in to the develop branch.

@mojoaxel
Copy link
Member

@wimrijnders Maybe you want to have a look a this? Maybe it's time to merge the 3d-camera-orientation finally?

@wimrijnders
Copy link
Contributor

wimrijnders commented Nov 22, 2016

привет @linuxnotes, хотя бы мне нравится видеть работу русскового программиста, по-моему лучше сохранять комментары по-англиский. Позвольте измените этот предложение.

Also, please heed the comment of @yotamberk. New stuff should go into the develop branch.

@mojoaxel mojoaxel merged commit 1aad815 into almende:3d-camera-orientation Nov 23, 2016
@mojoaxel
Copy link
Member

@linuxnotes Thanks for your changes! But as far as I understand @wimrijnders the 3d-camery-orientation branch is still not ready to get merged into develop. see also #2007.

@wimrijnders and @linuxnotes Feel free to improve the existing 3d-camery-orientation branch and create a pull-request if you think it is ready to get merged into develop.

@wimrijnders
Copy link
Contributor

@mojoaxel understood. I'll do any improvements in a separate PR.

mojoaxel pushed a commit that referenced this pull request Nov 23, 2016
@mojoaxel
Copy link
Member

mojoaxel commented Nov 23, 2016

@linuxnotes and @wimrijnders I just rebased the 3d-camery-orientationbranch on the current develop to keep it up to date. Please pull again.

@linuxnotes
Copy link
Contributor Author

Ok. Thanks.

@wimrijnders
Copy link
Contributor

OK pulled this branch. Everything works fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants