Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Adding width and height check #2436

Closed
wants to merge 2 commits into from
Closed

Adding width and height check #2436

wants to merge 2 commits into from

Conversation

spurdy
Copy link

@spurdy spurdy commented Dec 9, 2016

Adds a check for shape.width and shape.height in the 'isOverlappingWith' method, and issues a redraw if they are undefined. I believe this fixes issue #1847 that was causing the 'getNodeAt' method to not work in many of the event listeners.

@mojoaxel
Copy link
Member

@spurdy Thanks! That really looks like a nice fix!
But to be honest I'm not sure if a redraw is the right way to solve this problem. Redraws are usually expensive (big networks). We should figure out WHY the width and the height of the shape is null in the first place.
We should try together to figure it out for the next release. If we did not find a better sone in the next days, we should acceppt your solution! Thanks again!

@mojoaxel mojoaxel added this to the Minor Release v4.18 milestone Dec 29, 2016
@mojoaxel
Copy link
Member

Sorry, but I still don't feel comfortable merging this. I'll move it to v4.19.

@bradh
Copy link
Contributor

bradh commented Apr 14, 2017

@wimrijnders: Is this overtaken by #2885?

@wimrijnders
Copy link
Contributor

@wimrijnders: Is this overtaken by #2885?

Yes, that is correct. #2885 fixes the concerns that @mojoaxel had with #2436.

@bradh
Copy link
Contributor

bradh commented Apr 16, 2017

Overtaken by #2885.

@bradh bradh closed this Apr 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants