This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix YUI Compressor incompatibilities and improve JavaScript correctness #2452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2445
Reason for changes: (1) To allow the Vis distributed code to be processed by YUI Compressor (e.g. via tools such as Sencha Cmd, where it can be difficult not to use a compressor). (2) Improve general JavaScript correctness.
Summary of changes:
Changes to Vis application code:
1.1) Avoid using "boolean" as a variable name because it is a JavaScript reserved word. (Used "bool" instead.)
1.2) Avoid using "char" as a variable name because it is a JavaScript reserved word. (Used "ch" instead.)
Changes to Babel configuration:
2.1) Include the 'transform-es3-property-literals' Babel plugin to ensure that reserved words are quoted in object property keys, e.g.:
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { 'default': obj }; }
rather than:
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
2.2) Include the 'transform-es3-member-expression-literals' Babel plugin to ensure that reserved words are quoted in property accesses, e.g.:
return new _Configurator2['default'](this, this.dom.container, configureOptions);
rather than:
return new _Configurator2.default(this, this.dom.container, configureOptions);