This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Add callback functions to moveTo, zoomIn, zoomOut and setWindow #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
reviewed
Mar 26, 2017
| } | ||
| else { | ||
| animation = (options && options.animation !== undefined) ? options.animation : true; | ||
| this.range.setRange(start, end, animation); | ||
| this.range.setRange(start, end, { animation: animation }, callback); |
There was a problem hiding this comment.
This optional arguments / callback handling is starting to get pretty messy. Not sure of a better way - perhaps treating the callback as a option?
There was a problem hiding this comment.
Short answer: No.
I really think the callback function should be separated from the options.
It's not exactly an option and should be passed through in an object.
bradh
approved these changes
Apr 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkout #2805.
I've realized that @henev is right and there should be callback functions for timeline methods using animations. So I added this PR to have the ability to call a callback function right after the
setRangefinishes (after the animation is done). This is in addition torangechangeevent that gets called after these methods.