This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Eliminate repeatedly fired rangechanged events on mousewheel
#2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #397.
Notice that in the
vis/examples/timeline/interaction/eventListeners.htmltherangechangedevent is fired only at the end of a paused range change. The pause is hardcoded to be 200ms (standard default pause for a human reaction as given in jQuery and etc.)You might notice that the example loads with an initial log of a
rangechangedevent. I'm not 100% sure why only that event is fired whilst the others are not registered. They are all called on initial redraw. I guess this happens because of thesetTimeoutcalled (added with this PR) causes the code to have a cycle digest (a tick occurs) and then emits the events which causes the registration of that event in the log. In any case, this is not a big deal at all. The feature is much more important than the side-effect.