This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Refactoring and unit testing of Validator module #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added extra unit test for explicit |
wimrijnders
added a commit
to wimrijnders/vis
that referenced
this pull request
Jun 12, 2017
Fix for almende#3106 Event `stabilizationProgress` is now always sent for iteration 0 and for the very last stabilization iteration.
yotamberk
pushed a commit
that referenced
this pull request
Jun 13, 2017
Fix for #3106 Event `stabilizationProgress` is now always sent for iteration 0 and for the very last stabilization iteration.
yotamberk
approved these changes
Jul 20, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
…e#3165) Fix for almende#3106 Event `stabilizationProgress` is now always sent for iteration 0 and for the very last stabilization iteration.
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Added unit test for Validator, minimum viable version. * Added test-console to package list * Completed minimum viable unit test for Validator * Added Validator unit test for explicit 'undefined'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Validator.js, some comment cleanuptest-consoletopackage.jsonto aid the unit testsThe refactoring was mainly done to aid better understanding of the code. In addition, I will note here that this 'better understanding' is required to add some new features in the near future to
Validator, namely:Allow explicitly settingEdit: This works already, it's a matter of correctly defining valueundefinedfor options (required ingraph3d)undefinedfor a given field.deprecated.The unit test has been constructed in a manner that it tests all possible paths affected by the refactoring. Hence, the unit test is not complete; there is room for adding more tests here.