Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Added param 'direction' to Network.getConnectedNodes() #3108

Merged
merged 3 commits into from
May 30, 2017

Conversation

wimrijnders
Copy link
Contributor

This is a better resolution for #3091. The question of getting parents or children only gets asked regularly, so I think it's good to offer the option.

  • Added parameter direction to Network.getConnectedNodes(). Parent-only and child-only nodes can be selected with values from and to respectively.
  • Adjusted the documentation for this change.

This changes the API, so it presumably will be a MINOR version change.

Copy link
Contributor

@bradh bradh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty obvious in terms of implementation - even I could follow it.

@wimrijnders
Copy link
Contributor Author

@bradh 😄

@yotamberk yotamberk merged commit 0e6b6ec into almende:develop May 30, 2017
@wimrijnders wimrijnders deleted the getConnectedNodesFromTo branch May 31, 2017 07:28
@nadhir-falta
Copy link

Any estimate of when this will be released ?

@yotamberk
Copy link
Contributor

next week

primozs pushed a commit to primozs/vis that referenced this pull request Jan 3, 2019
* Added param 'direction' to Network.getConnectedNodes()

* Redo commit - Network.js does not need to change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants