This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Added dragStart event for adding edges. #3141
Merged
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmvenancio
approved these changes
Jul 10, 2017
yotamberk
approved these changes
Jul 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3131.
This adds a
dragStartevent when adding an edge using theManipulationsystem. No selected node and edge id's are passed with the event, because it doesn't make sense to pass them.There is no need to add a specific
dragEndfor adding an edge inManipulationSystem, the regular event fires already.Adding
dragStartanddragEndevents to the editing of a current edge has not been done. The problem here is that extra control nodes are added to the view to manipulate the edit. IndragStart, when trying to determine the starting node, what you get is the control node, and not the original node. I did not manage to find a way around this.