This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Adding caching to Range getMillisecondsPerPixel function #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yotamberk
approved these changes
Jun 13, 2017
| @@ -280,7 +282,10 @@ Range.prototype.setRange = function(start, end, options, callback) { | |||
| * Get the number of milliseconds per pixel. | |||
| */ | |||
| Range.prototype.getMillisecondsPerPixel = function() { | |||
| return (this.end - this.start) / this.body.dom.center.clientWidth; | |||
| if (this.millisecondsPerPixelCache === undefined) { | |||
There was a problem hiding this comment.
It would be cleaner if it would be:
if (!this.millisecondsPerPixelCache) { ... }
return this.millisecondsPerPixelCache
|
I like this very much, so i'll accept it! |
yotamberk
added a commit
to yotamberk/vis
that referenced
this pull request
Jul 2, 2017
move - FEAT almende#3154 to timeline
yotamberk
added a commit
that referenced
this pull request
Jul 2, 2017
* Fix redraw order * Fix error when option is not defined * Allow template labels * Add .travis.yml file * Add experiment travis code * Fix react example * created a checklist for the release process * unchecked everything * added make github release * Remove npm-debug logs * Release v4.20.1 * Update HISTORY.md Fix indents * Update HISTORY.md * Update HISTORY.md move - FEAT #3154 to timeline
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Fix redraw order * Fix error when option is not defined * Allow template labels * Add .travis.yml file * Add experiment travis code * Fix react example * created a checklist for the release process * unchecked everything * added make github release * Remove npm-debug logs * Release v4.20.1 * Update HISTORY.md Fix indents * Update HISTORY.md * Update HISTORY.md move - FEAT almende#3154 to timeline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some caching (a better name would be memoization) to Range.prototype.getMillisecondsPerPixel.
In my case, this function was responsible for quite some time (see attached chrome profiling), and from what I could understand, I could cache the results quite easily (as the results only changes after a "setRange").
Some bench marking, while adding some points to the timeline:
We can see some clear improvements (and the quadratic behavior!)