This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Refactoring of Node Drawing #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! ❤️ |
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Consolidated common code for drawing in nodes * Consolidated updateBoundingBox(), default version * Setting bounding box margin in separate method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods
draw()in all classes derived fromNodeBasecontain the same recurring blocks of code.These have been consolidated into method instances in
NodeBase.In addition, the common instances of method
updateBoundingBox()has been moved toNodeBase.A lot of source files have been touched, but if you diff, you'll see that it's mostly the common code blocks replaced by a single call.
This refactoring can be taken further, but I didn't want to make the review overly hard.