This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Network: make option 'hidden' and clustering play nice together #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for almende#3164 - `network.clustering.cluster()` now handles all nodes, not just the visible ones - Changing ivisibility of nodes now explicitly takes clustering into account, see `Network._updateVisibleIndices()` - `network.clustering` does not change `hidden` status any more. The important part of this PR is the realization that 'hidden' and 'clustered' are two distinct things and should be handled separately. In particular, clustering should **not** change the `hidden` state in any way.
yotamberk
approved these changes
Jul 20, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
Fix for almende#3164 - `network.clustering.cluster()` now handles all nodes, not just the visible ones - Changing ivisibility of nodes now explicitly takes clustering into account, see `Network._updateVisibleIndices()` - `network.clustering` does not change `hidden` status any more. The important part of this PR is the realization that 'hidden' and 'clustered' are two distinct things and should be handled separately. In particular, clustering should **not** change the `hidden` state in any way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3164
network.clustering.cluster()now handles all nodes, not just the visible onesNetwork._updateVisibleIndices()network.clusteringdoes not changehiddenstatus any more of nodes and edges.The important part of this PR is the realization that 'hidden' and 'clustered' are two distinct things and should be handled separately. In particular, clustering should not change the
hiddenstate in any way.To see the difference this PR makes, compare the original demo to the demo with fixes. In particular, the combination of 'hidden' with 'clustered' is important; try at least the following combinations.
Test 1:
Test 2:
Try any other combination you can think of as well.