Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

fix orientation option #3405

Merged
merged 1 commit into from
Sep 2, 2017
Merged

fix orientation option #3405

merged 1 commit into from
Sep 2, 2017

Conversation

keksa
Copy link
Contributor

@keksa keksa commented Sep 1, 2017

If Timeline is created with orientation option set and then options are updated using setOptions method with different option only, the original orientation should be kept, however the object is reset to {item:undefined,axis:undefined}.

example of the problem

var options = {
    timeAxis: {
        scale: 'hour',
        step: 1
    },
    orientation: 'top'
};
var timeline = new vis.Timeline($timeline.get(0), items, groups, options);

Orientation is now set to {item:'top',axis:'top'}

timeline.setOptions({
    timeAxis: {
        scale: 'hour',
        step: 2
    }
});

Orientation is now set to {item:undefined,axis:undefined}, which is incorrect behaviour.

wimrijnders added a commit to wimrijnders/vis that referenced this pull request Sep 1, 2017
A recurring problem during travis tests is that global variable `window` can get reset while `Network` tests using a mock canvas object are running.
This issue has been adressed several times, but it still happens. This PR reduces the possibility of it happening again to a minimum.

PR's affected by this issue should be merged with this fix and re-submitted. At time of writing, these are:
- almende#3402
- almende#3405
- almende#3399

Chances are it will occur sporadically for other PR's as well.
Labelling this `High Priority` because it indrectly affects unrelated PR's.
yotamberk pushed a commit that referenced this pull request Sep 2, 2017
)

A recurring problem during travis tests is that global variable `window` can get reset while `Network` tests using a mock canvas object are running.
This issue has been adressed several times, but it still happens. This PR reduces the possibility of it happening again to a minimum.

PR's affected by this issue should be merged with this fix and re-submitted. At time of writing, these are:
- #3402
- #3405
- #3399

Chances are it will occur sporadically for other PR's as well.
Labelling this `High Priority` because it indrectly affects unrelated PR's.
Copy link
Contributor

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@yotamberk yotamberk merged commit f405fe8 into almende:develop Sep 2, 2017
primozs pushed a commit to primozs/vis that referenced this pull request Jan 3, 2019
…mende#3406)

A recurring problem during travis tests is that global variable `window` can get reset while `Network` tests using a mock canvas object are running.
This issue has been adressed several times, but it still happens. This PR reduces the possibility of it happening again to a minimum.

PR's affected by this issue should be merged with this fix and re-submitted. At time of writing, these are:
- almende#3402
- almende#3405
- almende#3399

Chances are it will occur sporadically for other PR's as well.
Labelling this `High Priority` because it indrectly affects unrelated PR's.
primozs pushed a commit to primozs/vis that referenced this pull request Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants