This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Revert "Group redraw performance" #3451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9830616.
|
Crap. Here is me the reviewer and I let it pass. Sorry (but my knowledge of |
wimrijnders
approved these changes
Sep 18, 2017
There was a problem hiding this comment.
OK, by the looks of it you just undid the changes of #3409. I'm good with that.
Perhaps in next round you can add the changes in stages, to see where it fails.
|
It was my fault. I thought i was pedantic about it and only after the merge i found this bug... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3409
this causes a big problem in changing ranged items....
I'll fix this first before remerging