Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Timeline: Added describe-sections to PointItem unit tests #3509

Merged
merged 1 commit into from
Oct 1, 2017

Conversation

wimrijnders
Copy link
Contributor

Small fix on the unit tests for better output layout. Before the fix:

 Timeline PointItem
    ✓ should initialize with minimal data
    ✓ should have a default width of 0
    ✓ should error if there is missing data
    ✓ should be visible if the range is during
    ✓ should not be visible if the range is after
    ✓ should not be visible if the range is before
    ✓ should be visible for a "now" point with a default range
    ✓ should redraw() and then not be dirty
    ✓ should redraw() and then have point attached to its parent
    ✓ should redraw() and then have the correct classname for a non-editable item
    ✓ should redraw() and then have the correct classname for an editable item (with object option)
    ✓ should redraw() and then have the correct classname for an editable item (with boolean option)
    ✓ should redraw() and then have the correct classname for an editable:false override item (with boolean option)
    ✓ should redraw() and then have the correct classname for an editable:true override item (with boolean option)
    ✓ should redraw() and then have the correct classname for an editable:false override item (with object option)
    ✓ should redraw() and then have the correct classname for an editable:false override item (with object option for group change)
    ✓ should redraw() and then have the correct classname for an editable:true override item (with object option)
    ✓ should redraw() and then have the correct classname for an editable:true non-override item (with object option)
    ✓ should redraw() and then have the correct classname for an editable:false non-override item (with object option)
    ✓ should redraw() and then have the correct property for an editable: {updateTime} override item (with boolean option)
    ✓ should redraw() and then have the correct property for an editable: {updateTime} override item (with boolean option false)
    ✓ should redraw() and then have the correct property for an editable: {updateGroup} override item (with boolean option)
    ✓ should redraw() and then have the correct property for an editable: {updateGroup} override item (with boolean option false)
    ✓ should redraw() and then have the correct property for an editable: {remove} override item (with boolean option)
    ✓ should redraw() and then have the correct property for an editable: {remove} override item (with boolean option false)
    ✓ should redraw() and then have the correct property for an editable: {updateTime, remove} override item (with boolean option)
    ✓ should redraw() and then have the correct property for an editable: {updateTime, remove} override item (with boolean option false)
    ✓ should redraw() and then have the correct property for an editable: {updateTime, updateGroup, remove} override item (with boolean option)
    ✓ should redraw() and then have the correct property for an editable: {updateTime, updateGroup, remove} override item (with boolean option false)

With this fix:

Timeline PointItem
    ✓ should initialize with minimal data
    ✓ should have a default width of 0
    ✓ should error if there is missing data
    ✓ should be visible if the range is during
    ✓ should not be visible if the range is after
    ✓ should not be visible if the range is before
    ✓ should be visible for a "now" point with a default range
    should redraw() and then
      ✓ not be dirty
      ✓ have point attached to its parent
      have the correct classname for
        ✓ a non-editable item
        ✓ an editable item (with object option)
        ✓ an editable item (with boolean option)
        ✓ an editable:false override item (with boolean option)
        ✓ an editable:true override item (with boolean option)
        ✓ an editable:false override item (with object option)
        ✓ an editable:false override item (with object option for group change)
        ✓ an editable:true override item (with object option)
        ✓ an editable:true non-override item (with object option)
        ✓ an editable:false non-override item (with object option)
        ✓ an editable: {updateTime} override item (with boolean option)
        ✓ an editable: {updateTime} override item (with boolean option false)
        ✓ an editable: {updateGroup} override item (with boolean option)
      have the correct property for
        ✓ an editable: {updateGroup} override item (with boolean option false)
        ✓ an editable: {remove} override item (with boolean option)
        ✓ an editable: {remove} override item (with boolean option false)
        ✓ an editable: {updateTime, remove} override item (with boolean option)
        ✓ an editable: {updateTime, remove} override item (with boolean option false)
        ✓ an editable: {updateTime, updateGroup, remove} override item (with boolean option)
        ✓ an editable: {updateTime, updateGroup, remove} override item (with boolean option false)

Copy link
Contributor

@macleodbroad-wf macleodbroad-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yotamberk yotamberk merged commit 4b489a1 into almende:develop Oct 1, 2017
@wimrijnders wimrijnders deleted the describePointItem branch October 22, 2017 09:38
primozs pushed a commit to primozs/vis that referenced this pull request Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants