This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Item Redraw Performance - Bug Fix #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an object, not an array, so it cannot be iterated over using a normal for loop. Not repositioning the items causes the vertical stacking to jump around sporatically while scrolling.
yotamberk
suggested changes
Oct 2, 2017
lib/timeline/component/Group.js
Outdated
| for (i = 0; i < this.items.length; i++) { | ||
| this.items[i].repositionX(limitSize); | ||
| } | ||
| util.forEach(this.items, function (item, key) { |
There was a problem hiding this comment.
Please remove the key.
The linting is failing.
yotamberk
approved these changes
Oct 2, 2017
|
nvm, I fixed it. |
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Fixing a bug with the call to `repositionX`. The `items` collection is an object, not an array, so it cannot be iterated over using a normal for loop. Not repositioning the items causes the vertical stacking to jump around sporatically while scrolling. * Update Group.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #3475, specifically my comment made on 10/1/2017 regarding the performance enhancement causing the vertical position of items to jump around while scrolling horizontally. The issue was due to the calls being made to
repositionXon each item not happening. Theitemcollection on theGroupclass are an object, not an array, so the normalforloop wasn't doing anything. Changed it to use the utilityforEachmethod which seems to have resolved the issue.