fixed bug that did not allocate the correct array if there is a remov…

[AlexDM0]

Hi guys,

I encountered an issue where I have a vis dataset loaded into a graph2d and on removal (.clear() method) of all items, the graph did not redraw correctly. On updating afterwards it threw an Error.

Took quite a bit of digging but it turns out the optimization of the memory allocation does not account for deleted items. the onRemove method forwards to the onUpdate method which should not be done anymore if the group update blindly expects the items to be updated, not deleted.

This is more of an indication, you don't need to accept the request. Normally, this request would go to develop but I really didnt feel like comparing develop branches :)

Cheers

[AlexDM0]

Just FYI, redraw speed of graph2d is MUCH much worse in 4.21 than it was in 4.18.

[Tooa]

Can you provide an example showing the redraw regression issues between 4.21 and 4.18? We may open a ticket with your example then. Someone might pick it up to investigate.

[AlexDM0]

Anything with updating a large dataset of say 4000 items multiple times a second works. Try to tax the 4.21 and then try it with 4.18. I don’t have an example on hand.

…

________________________________ From: Uli Fahrer <notifications@github.com> Sent: Monday, April 2, 2018 7:13:34 PM To: almende/vis Cc: Alex; Author Subject: Re: [almende/vis] fixed bug that did not allocate the correct array if there is a remov… (#3814) Can you provide an example showing the redraw regression issues between 4.21 and 4.18? We may open a ticket with your example then. Someone might pick it up to investigate. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3814 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFHWTSD_RZK56XeaYU8Fd5Ozd7uKFoSZks5tklw9gaJpZM4SAOr8>.