Exposed public classes under System namespace cause conflicts with other third party libraries

[dfaivre]

Issue description

Specifically:

parquet-dotnet/src/NetBox.cs

Line 1914 in eb82887

public static byte[]? ToByteArray(this Stream? stream) {

It probably wouldn't collide as much but a lot of the functions are declared under the root System namespace - so they are automatically imported.

Could these classes/functions be made internal - or at least the ones declared in the System namespace?

Very useful project - thank you for all the work!

[aloneguid]

Good catch, thank you. They shutoff be all internal, it's a bug

[aloneguid]

released

[dfaivre]

Thank you!

…

On Thu, Jan 11, 2024 at 3:27 AM Ivan G ***@***.***> wrote: Closed #451 <#451> as completed. — Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJH27DGWRY2QVZBYUQBJNTYN6V7XAVCNFSM6AAAAABBR2UXWSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ2TGOBYGAYDMNA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[aloneguid]

I'm glad you found it useful :) If you liked it, please consider giving it a star rating, it really makes a difference.

[dfaivre]

Done!