Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/encode json numbers with invariant culture #438

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix/encode json numbers with invariant culture #438

merged 2 commits into from
Dec 13, 2023

Conversation

rachied
Copy link

@rachied rachied commented Dec 7, 2023

Explicitly use invariant culture when encoding number types, eliminating the potential for generating invalid JSON.

Fixes #133

@aloneguid aloneguid self-requested a review December 13, 2023 13:20
aloneguid
aloneguid approved these changes Dec 13, 2023
View reviewed changes
Copy link
Owner

@aloneguid aloneguid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

@aloneguid aloneguid merged commit 4edf100 into aloneguid:master Dec 13, 2023
5 checks passed
@aloneguid aloneguid added this to the 4.18.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloneguid aloneguid aloneguid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.18.0
Development

Successfully merging this pull request may close these issues.

Question: How would I specify CultureInfo.InvariantCulture alongside table.ToString("j")
2 participants
@rachied @aloneguid