Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decimal scale condition #504

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

sierzput
Copy link
Contributor

Fix for #503

@sierzput
Copy link
Contributor Author

Hi @aloneguid, I introduced small fix, but there are some failing tests for macos-latest. Could you help me with them? I'm not sure if it's connected to my change.

@aloneguid
Copy link
Owner

mac builds were failing due to M1 issues with java, it's all good now

Copy link
Owner

@aloneguid aloneguid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloneguid aloneguid added this to the 4.24.0 milestone May 22, 2024
@aloneguid aloneguid merged commit b5464d6 into aloneguid:master May 22, 2024
8 of 9 checks passed
@mshatnawi
Copy link

mshatnawi commented May 24, 2024

Hi @aloneguid
Is this fix included in version 4.24.0-pre.1, and if not what version should I rollback to to avoid this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants